Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1847: improve modules js generation #123

Merged
merged 1 commit into from
Mar 22, 2024
Merged

OP-1847: improve modules js generation #123

merged 1 commit into from
Mar 22, 2024

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Mar 21, 2024 •
edited by jira bot
Loading

OP-1847

Changes:

  • Include a try-catch block around each module loading operation.
  • If there is an error, it will trigger an alert informing about the failure and log the error details to the console.
  • The error will be alerted to the user, but it won't halt the loading process of other modules.

@olewandowski1 olewandowski1 requested review from delcroip, sniedzielski and a user March 21, 2024 10:04
@olewandowski1 olewandowski1 marked this pull request as ready for review March 21, 2024 10:04
ghost
ghost approved these changes Mar 21, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delcroip delcroip merged commit 2cccd38 into develop Mar 22, 2024
4 checks passed
@delcroip delcroip deleted the feature/OP-1847 branch March 22, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delcroip delcroip Awaiting requested review from delcroip

@sniedzielski sniedzielski Awaiting requested review from sniedzielski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olewandowski1 @delcroip